Fix MA0003 Fix All producing invalid named-argument rewrites in multi-argument calls#1168
Merged
Merged
Conversation
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with MA0003 auto code fix
Fix MA0003 Fix All producing invalid named-argument rewrites in multi-argument calls
May 21, 2026
meziantou
approved these changes
May 21, 2026
This was referenced May 21, 2026
Closed
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
May 22, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.90 to 3.0.91. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.91 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.91> ## What's Changed * Fix MA0003 Fix All producing invalid named-argument rewrites in multi-argument calls by @Copilot in meziantou/Meziantou.Analyzer#1168 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.90...3.0.91 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.90...3.0.91). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 22, 2026
This was referenced May 28, 2026
Open
Open
Chris-Wolfgang
added a commit
to Chris-Wolfgang/DbContextBuilder
that referenced
this pull request
May 29, 2026
Updated [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 10.0.0 to 10.0.1. <details> <summary>Release notes</summary> _Sourced from [coverlet.collector's releases](https://github.com/coverlet-coverage/coverlet/releases)._ ## 10.0.1 ### Improvements - Coverlet with MTP 2 doesn't show test coverage statistic in console [#1907](coverlet-coverage/coverlet#1907) - Avoid unnecessary testhost restarts [#1912](coverlet-coverage/coverlet#1912) by <https://github.com/mawosoft> ### Fixed - Fix inconsistent paths in cobertura reports [#1723](coverlet-coverage/coverlet#1723) - Fix when using "is" with "and" in pattern matching, branch coverage is lower than normal [#1313](coverlet-coverage/coverlet#1313) - Fix Coverlet flagging a branch for an async functions finally block where none exists [#1337](coverlet-coverage/coverlet#1337) - Fix Coverlet Tracker Missing CompilerGeneratedAttribute [#1828](coverlet-coverage/coverlet#1828) ### Maintenance - Add architecture docs and diagrams for all integrations [#1927](coverlet-coverage/coverlet#1927) - Update NuGet packages and .NET SDK versions [#1933](coverlet-coverage/coverlet#1933) [Diff between 10.0.0 and 10.0.1](coverlet-coverage/coverlet@v10.0.0...v10.0.1) Commits viewable in [compare view](coverlet-coverage/coverlet@v10.0.0...v10.0.1). </details> Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.85 to 3.0.93. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.93 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.93> ## What's Changed * Fix MA0148/MA0149 false positives with implicit conversions by @meziantou in meziantou/Meziantou.Analyzer#1170 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.92...3.0.93 ## 3.0.92 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.92> ## What's Changed * Add analyzer for identical conditional compilation branches by @meziantou in meziantou/Meziantou.Analyzer#1169 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.91...3.0.92 ## 3.0.91 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.91> ## What's Changed * Fix MA0003 Fix All producing invalid named-argument rewrites in multi-argument calls by @Copilot in meziantou/Meziantou.Analyzer#1168 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.90...3.0.91 ## 3.0.90 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.90> ## What's Changed * Fix MA0071 false positive for `else if` chains with reachable prior branches by @Copilot in meziantou/Meziantou.Analyzer#1166 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.89...3.0.90 ## 3.0.89 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.89> ## What's Changed * Add opt-in MA0134 reporting for discarded awaitables by @meziantou in meziantou/Meziantou.Analyzer#1164 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.88...3.0.89 ## 3.0.88 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.88> ## What's Changed * Add MA0201 for zero-valued enum flag checks by @meziantou in meziantou/Meziantou.Analyzer#1163 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.87...3.0.88 ## 3.0.87 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.87> ## What's Changed * Fix MA0194 merge with existing and-patterns by @meziantou in meziantou/Meziantou.Analyzer#1162 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.86...3.0.87 ## 3.0.86 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.86> ## What's Changed * Improve MA0192 HasFlag detection for zero comparisons by @meziantou in meziantou/Meziantou.Analyzer#1161 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.85...3.0.86 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.85...3.0.93). </details> Updated [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 10.25.0.139117 to 10.26.0.140279. <details> <summary>Release notes</summary> _Sourced from [SonarAnalyzer.CSharp's releases](https://github.com/SonarSource/sonar-dotnet/releases)._ ## 10.26.0.140279 # Release notes - .NET Analyzers - 10.26 ### Feature [NET-3694](https://sonarsource.atlassian.net/browse/NET-3694) Update RSPEC before 10.26 release ### False Positive [NET-2346](https://sonarsource.atlassian.net/browse/NET-2346) Fix S1854 FP: Variable used after another assignment in finally [NET-2347](https://sonarsource.atlassian.net/browse/NET-2347) Fix S1168 FP: Do not report on value types [NET-3698](https://sonarsource.atlassian.net/browse/NET-3698) Fix S1210 FP: file-scoped types should be exempt ### False Negative [NET-1265](https://sonarsource.atlassian.net/browse/NET-1265) Fix S2930 FN: raise issues on non-disposed RegistryKeys [NET-2685](https://sonarsource.atlassian.net/browse/NET-2685) Fix S3604 FN: Field Keyword, Partial Constructors, NullConditional Assignment [NET-2812](https://sonarsource.atlassian.net/browse/NET-2812) Fix S4275 FN: Field Keyword [NET-2999](https://sonarsource.atlassian.net/browse/NET-2999) Fix S6672 FN: Mismatch in primary constructor is not recognized Commits viewable in [compare view](https://github.com/SonarSource/sonar-dotnet/commits/10.26.0.140279). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0003’s code fix could misapply parameter names when multiple arguments in the same invocation were fixed together, producing invalid syntax by stacking name colons onto one argument. This updates Fix All behavior to apply argument naming deterministically per diagnostic span.
Fix All behavior for MA0003
NamedParameterFixAllProviderforNamedParameterFixer.WellKnownFixAllProviders.BatchFixerfor this rule.Fixer refactor for span-driven application
ArgumentSyntaxafter prior edits.Regression coverage
BatchFix_MultipleArgumentsInSingleInvocationtoNamedParameterAnalyzerTests.nullarguments in one invocation must all be named.